changed RpcClient signature to use method UUri only when calling#326
Conversation
|
Code coverage report is ready! 📈
|
PLeVasseur
left a comment
PLeVasseur
left a comment
There was a problem hiding this comment.
Thanks @MaximilianToe! The way you approached it makes sense to me.
Was wondering if you've added tests which would test the new case of an invalid method being passed into invokeMethod(). I looked through a bit, but didn't find it. 😅
Ah, I forgot to write a new test for the new case. Will add this to this PR. |
Gotcha, thanks for checking my eyesight 👓 |
|
Code coverage report is ready! 📈
|
PLeVasseur
left a comment
PLeVasseur
left a comment
There was a problem hiding this comment.
Thanks for adding these additional tests @MaximilianToe!
LGTM
2 participants
This PR changes the way the method Uuri is passed to the RpcClient. It is now passed when calling InvokeMethod instead of when building the client. This allows the user to reuse a single RpcClient instance for multiple methods.
Closes #325